fix(ui): Add claim name for Custom SAML provider in `<ConfigureSSO />` by LauraBeatris · Pull Request #8586 · clerk/javascript

LauraBeatris · 2026-05-18T18:47:18Z

Description

This PR fixes the attribute statements step for Custom SAML provider, where previously was displaying the claim value with an expression that is specific to Okta

It also fixes an issue on the test step, where it was always disabling the button, but the validation actually happens on click.

Custom SAML

Okta

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2026-05-18T18:47:24Z

🦋 Changeset detected

Latest commit: 0a8f3f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages

Name	Type
@clerk/localizations	Patch
@clerk/clerk-js	Patch
@clerk/shared	Patch
@clerk/ui	Patch
@clerk/react	Patch
@clerk/chrome-extension	Patch
@clerk/expo	Patch
@clerk/astro	Patch
@clerk/backend	Patch
@clerk/expo-passkeys	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/hono	Patch
@clerk/msw	Patch
@clerk/nextjs	Patch
@clerk/nuxt	Patch
@clerk/react-router	Patch
@clerk/tanstack-react-start	Patch
@clerk/testing	Patch
@clerk/vue	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2026-05-18T18:47:24Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
clerk-js-sandbox	Ready	Preview, Comment	May 18, 2026 6:57pm

pkg-pr-new · 2026-05-18T18:51:43Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8586

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8586

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8586

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8586

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8586

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8586

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8586

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8586

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8586

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8586

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8586

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8586

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8586

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8586

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8586

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8586

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8586

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8586

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8586

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8586

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8586

commit: 0a8f3f3

coderabbitai · 2026-05-18T18:52:20Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: df0a895d-ac3d-4f89-b5b2-48b8e0c940e4

📥 Commits

Reviewing files that changed from the base of the PR and between d4fc01a and 0a8f3f3.

📒 Files selected for processing (2)

.changeset/fancy-zoos-mate.md
packages/ui/src/components/ConfigureSSO/steps/TestConfigurationStep.tsx

💤 Files with no reviewable changes (1)

packages/ui/src/components/ConfigureSSO/steps/TestConfigurationStep.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

.changeset/fancy-zoos-mate.md

📝 Walkthrough

Walkthrough

This PR extends the component to add an Okta-specific claim value column to the attribute mapping table. The localization type definition gains a new claimValue field, and en-US strings are updated with the column header and example claim values. The ConfigureStep component conditionally renders the claim value column only when the provider is Okta, using the new localization keys. The TestConfigurationStep component has its Continue button's isDisabled prop removed, letting button state be controlled purely by the onClick handler and isLoading flag. Patch releases are recorded for four affected packages.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

clerk/javascript#8535: The main PR’s updates to packages/ui/src/components/ConfigureSSO/steps/ConfigureStep.tsx (adding the Okta-specific “claim value” column and wiring oktaClaimValue/isOkta) build directly on the retrieved PR’s Okta Configure step UI/table work in the same ConfigureStep flow.
clerk/javascript#8564: Both PRs modify the same <ConfigureSSO /> configure-step stack—updating the shared SSO localization/type schema and the packages/ui/src/components/ConfigureSSO/steps/ConfigureStep.tsx UI with provider-specific (Okta/custom SAML) rendering—so the main PR’s new Okta “claim value” column fits into the custom/Okta SAML support introduced by the retrieved PR.
clerk/javascript#8544: The main PR’s change to packages/ui/src/components/ConfigureSSO/steps/TestConfigurationStep.tsx (removing the isDisabled/isConnectionActive continue-button wiring) directly overlaps the retrieved PR’s newly added/rewired ConfigureSSO test step footer/continue behavior.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main fix: adding the correct claim name for Custom SAML provider in the ConfigureSSO component, which aligns with the core changes across all modified files.
Description check	✅ Passed	The description is clearly related to the changeset, explaining the Custom SAML fix and the test step issue, with visual evidence via screenshots showing the before/after UI for both Custom SAML and Okta providers.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

LauraBeatris added 2 commits May 18, 2026 15:38

Display only claim value for custom SAML

7677328

Do not disable continue on test step

5d1d4ed

LauraBeatris self-assigned this May 18, 2026

github-actions Bot added localizations ui labels May 18, 2026

LauraBeatris requested a review from a team May 18, 2026 18:47

Add changeset

0a8f3f3

LauraBeatris force-pushed the laura/fix-attribute-mapping branch from d4fc01a to 0a8f3f3 Compare May 18, 2026 18:56

vercel Bot deployed to Preview May 18, 2026 18:57 View deployment

gabrielmeloc22 approved these changes May 18, 2026

View reviewed changes

LauraBeatris merged commit 95f6c2f into main May 18, 2026
45 checks passed

LauraBeatris deleted the laura/fix-attribute-mapping branch May 18, 2026 19:09

clerk-cookie mentioned this pull request May 18, 2026

ci(repo): Version packages #8585

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ui): Add claim name for Custom SAML provider in `<ConfigureSSO />`#8586

fix(ui): Add claim name for Custom SAML provider in `<ConfigureSSO />`#8586
LauraBeatris merged 3 commits into
mainfrom
laura/fix-attribute-mapping

LauraBeatris commented May 18, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented May 18, 2026 •

edited

Loading

Uh oh!

vercel Bot commented May 18, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented May 18, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 18, 2026 •

edited

Loading

Walkthrough

Estimated code review effort

Possibly related PRs

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

LauraBeatris commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Custom SAML

Okta

Checklist

Type of change

Uh oh!

changeset-bot Bot commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel Bot commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Possibly related PRs

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LauraBeatris commented May 18, 2026 •

edited

Loading

changeset-bot Bot commented May 18, 2026 •

edited

Loading

vercel Bot commented May 18, 2026 •

edited

Loading

pkg-pr-new Bot commented May 18, 2026 •

edited

Loading

coderabbitai Bot commented May 18, 2026 •

edited

Loading